Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for results and time ranges #733

Merged
merged 7 commits into from
Sep 6, 2023
Merged

feat: Add support for results and time ranges #733

merged 7 commits into from
Sep 6, 2023

Conversation

bjchambers
Copy link
Collaborator

@bjchambers bjchambers commented Sep 1, 2023

This adds the plumbing to use History and Snapshot result configurations. It adds the necessary decoration code to the session.

This adds the plumbing to use History and Snapshot result
configurations. It adds the necessary decoration code to the session.

- [ ] Review tests / time -- looks like time zones cause some errors
- [ ] Get final snapshot test passing (or indicate it is expected to fail)
@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Sep 1, 2023
@github-actions github-actions bot added enhancement New feature or request sparrow labels Sep 1, 2023
@bjchambers bjchambers marked this pull request as ready for review September 1, 2023 15:33
crates/sparrow-session/src/session.rs Show resolved Hide resolved
crates/sparrow-session/src/session.rs Show resolved Hide resolved
crates/sparrow-session/src/session.rs Show resolved Hide resolved
crates/sparrow-runtime/src/execute.rs Show resolved Hide resolved
python/pysrc/kaskada/_execution.py Show resolved Hide resolved
python/pysrc/kaskada/_execution.py Show resolved Hide resolved
python/pytests/conftest.py Outdated Show resolved Hide resolved
python/pytests/conftest.py Outdated Show resolved Hide resolved
@bjchambers bjchambers added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit aaee541 Sep 6, 2023
32 checks passed
@bjchambers bjchambers deleted the snapshots branch September 6, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Set when all authors of a PR have signed our CLA enhancement New feature or request sparrow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants